Skip to content

Conversation

@i-chaochen
Copy link
Collaborator

@i-chaochen i-chaochen commented Oct 27, 2025

Motivation

rm unused gcc build and unify bazelrc, and avoid others use bazel config=rocm incorrectly again.

Test Plan

to avoid this issue again SWDEV-562886

this needs to upstream and rocm-jaxlib-v0.7.1 as well.

Copy link

@hsharsha hsharsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please remove all the rocm_base config definitions as well.

@i-chaochen i-chaochen force-pushed the ci_correct_bazel_rocm_Config branch from ab1bffe to 42404e4 Compare October 27, 2025 17:58
@i-chaochen
Copy link
Collaborator Author

Also please remove all the rocm_base config definitions as well.

build:rocm --config=rocm_clang_official
build:rocm_ci --config=rocm_clang_official

I guess we don't need rocm_ci as well? just keep rocm ? If I rm it, does it mean we need to change it in CI... https://github.com/ROCm/rocAutomation/blob/jenkins-pipelines/vars/openxlaUtils.groovy ?

@alekstheod

@hsharsha
Copy link

Please don't rm rocm_ci XLA test scripts run_xla.sh and run_xla_multi_gpu.sh are changed to use rocm_ci. We need to change them as well. Also we need to change rocAutomation as we pass rocm_ci there as well for upstream and other jobs

@i-chaochen
Copy link
Collaborator Author

i-chaochen commented Oct 27, 2025

Please don't rm rocm_ci XLA test scripts run_xla.sh and run_xla_multi_gpu.sh are changed to use rocm_ci. We need to change them as well. Also we need to change rocAutomation as we pass rocm_ci there as well for upstream and other jobs

Yes, I didn't, just realise seems two duplicate ones..

@i-chaochen
Copy link
Collaborator Author

i-chaochen commented Oct 30, 2025

Also please remove all the rocm_base config definitions as well.

@hsharsha I just realise I cannot rm rocm_base and only keep rocm for these

build:rocm --copt=-Wno-gnu-offsetof-extensions
build:rocm --crosstool_top=@local_config_rocm//crosstool:toolchain
build:rocm --define=using_rocm_hipcc=true
build:rocm --define=tensorflow_mkldnn_contraction_kernel=0
build:rocm --define=xnn_enable_avxvnniint8=false
build:rocm --define=xnn_enable_avx512fp16=false
build:rocm --repo_env TF_NEED_ROCM=1

it will cause config cycle for final rocm config..

@i-chaochen i-chaochen merged commit 62f6e69 into rocm-jaxlib-v0.6.0 Nov 3, 2025
6 of 8 checks passed
i-chaochen added a commit that referenced this pull request Nov 4, 2025
i-chaochen added a commit that referenced this pull request Nov 4, 2025
mmakevic-amd pushed a commit that referenced this pull request Nov 14, 2025
)

Imported from GitHub PR openxla#33534

📝 Summary of Changes
rm unused rocm config and unify it as clang only

🎯 Justification
previous `--config=rocm` is not used at all.

🚀 Kind of Contribution
Please remove what does not apply: 🐛 Bug Fix,   ♻️ Cleanup,

@xla-rotation @ddunl please review and thanks!

Copybara import of the project:

--
0507e40 by Chao <[email protected]>:

rm gcc bazelrc and unify rocm_ci and rocm (#412)

* resolve the config cycle

Merging this change closes openxla#33534

COPYBARA_INTEGRATE_REVIEW=openxla#33534 from ROCm:ci_unify_rocm_config 0507e40
PiperOrigin-RevId: 831896150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants