-
Notifications
You must be signed in to change notification settings - Fork 6
rm gcc bazelrc and unify rocm_ci and rocm #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hsharsha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please remove all the rocm_base config definitions as well.
ab1bffe to
42404e4
Compare
I guess we don't need |
|
Please don't rm rocm_ci XLA test scripts run_xla.sh and run_xla_multi_gpu.sh are changed to use rocm_ci. We need to change them as well. Also we need to change rocAutomation as we pass rocm_ci there as well for upstream and other jobs |
Yes, I didn't, just realise seems two duplicate ones.. |
@hsharsha I just realise I cannot rm it will cause config cycle for final |
) Imported from GitHub PR openxla#33534 📝 Summary of Changes rm unused rocm config and unify it as clang only 🎯 Justification previous `--config=rocm` is not used at all. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ♻️ Cleanup, @xla-rotation @ddunl please review and thanks! Copybara import of the project: -- 0507e40 by Chao <[email protected]>: rm gcc bazelrc and unify rocm_ci and rocm (#412) * resolve the config cycle Merging this change closes openxla#33534 COPYBARA_INTEGRATE_REVIEW=openxla#33534 from ROCm:ci_unify_rocm_config 0507e40 PiperOrigin-RevId: 831896150
Motivation
rm unused gcc build and unify bazelrc, and avoid others use
bazel config=rocmincorrectly again.Test Plan
to avoid this issue again SWDEV-562886
this needs to upstream and rocm-jaxlib-v0.7.1 as well.